Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000823Taste[All Projects] ASN.1 Compiler v4public2018-12-15 09:252019-01-12 15:23
Reportercavada@fbk.eu 
Assigned Togmamais 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusresolvedResolutionfixed 
PlatformOSOS Version
Summary0000823:

Generated ICD contains non-existent fields

Description

When using determinants for choice (and perhaps with other types), ICD documentation contains wrong information.

For example:

----- ASN1:
T-NID-Packet ::= ENUMERATED
{
stm-0 (0),

stm-5      (5),
stm-8      (8),
stm-9      (9),
stm-13    (13),
stm-14    (14),
stm-15    (15),
stm-32    (32),
stm-35    (35),
stm-45    (45),

stm-199  (199)

}

T-Packet-Body ::= CHOICE
{
stm-0 T-Packet-STM-empty-body,

stm-5   T-Packet-STM5-body,
stm-8   T-Packet-STM8-body,
stm-9   T-Packet-STM9-body,
stm-13  T-Packet-STM13-body,
stm-14  T-Packet-STM14-body,
stm-15  T-Packet-STM15-body,
stm-32  T-Packet-STM32-body,
stm-35  T-Packet-STM35-body,
stm-45  T-Packet-STM45-body,

stm-199 T-Packet-STM-empty-body

}

----- ACN:
T-Packet []
{
nid T-NID-Packet [encode-values],
length NULL [pattern '0000000000000'B], -- 13 bits

pbody [determinant nid]
}

Will generate ICD fragment for T-Packet-Body in attached image.
Here 4-bit ACN field 'ChoiceIndex' is document, although corresponding T-Packet.nid is used as determinant.

TagsNo tags attached.
Attached Filespng file icon Screenshot from 2018-12-15 10-21-13.png [^] (50,572 bytes) 2018-12-15 09:25

- Relationships

-  Notes
(0003552)
maxime (administrator)
2018-12-15 17:15

I don't think it is wrong to have the ChoiceIndex here. You may want to call Encode on a variable of type T-Packet-Body independently from T-Packet, and in that case the choice index would be there.

However it is true that in the ICD of T-Packet (which is correct in terms of number of bits to use) the hyperlink to T-Packet-Body encoding is incorrect since it uses a different encoding in that specific context.

I am not sure of the best way to fix that: have another table for the custom encoding of the nested T-Packet-Body (but the pointer to the choice index would not be obvious), or embed the rows inside the table T-Packet.

(0003555)
gmamais (developer)
2019-01-12 15:23

Fixed by introducing a new table for the custom encoding of the nested T-Packet-Body.


- Issue History
Date Modified Username Field Change
2018-12-15 09:25 cavada@fbk.eu New Issue
2018-12-15 09:25 cavada@fbk.eu File Added: Screenshot from 2018-12-15 10-21-13.png
2018-12-15 17:01 maxime Assigned To

=> gmamais

2018-12-15 17:01 maxime Status

new => assigned

2018-12-15 17:15 maxime Note Added: 0003552
2019-01-12 15:23 gmamais Note Added: 0003555
2019-01-12 15:23 gmamais Status

assigned => resolved

2019-01-12 15:23 gmamais Resolution

open => fixed



Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker